Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rect): fix arithmetic overflow edge cases #543

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(rect): fix arithmetic overflow edge cases #543

merged 1 commit into from
Sep 28, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Sep 28, 2023

Fixes #258

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #543 (82fc9e8) into main (9cfb133) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files          41       41           
  Lines       11437    11437           
=======================================
  Hits        10254    10254           
  Misses       1183     1183           
Files Coverage Δ
src/layout/rect.rs 98.98% <100.00%> (ø)

@joshka joshka merged commit 11076d0 into main Sep 28, 2023
33 checks passed
@joshka joshka deleted the rect-overflow branch September 28, 2023 10:19
tonogdlp pushed a commit to tonogdlp/ratatui that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rect: Arithmetic overflow occurs in intersection, intersects, and union
3 participants